On Linux default use_static_cpp to disabled
#1878
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I dont know how to propose changes inline in the code, but in the linux.cmake:22 set(STATIC_CPP "$<BOOL:${GODOTCPP_USE_STATIC_CPP}>")can be changed to: set(STATIC_CPP "$<AND:$<BOOL:${GODOTCPP_USE_STATIC_CPP}>,$<BOOL:${GODOTCPP_USE_HOT_RELOAD}>>")99.9% sure this is correct, I just cant test on linux atm. |
Collaborator
Author
|
I'm not sure if I'm reading it correctly, but it looks like your change would set STATIC_CPP if both If so, I don't think that's what we want. If anything, I think we'd want it to only be set if |
Collaborator
|
crap I thought thats the PR i was commenting on, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1876
This implements option nr 1, which I guess I'm leaning to, because it's the least surprising. This option has only existed for a short time, so changing the default shouldn't be too big of a deal